Cmake tweaks #110
Open
Cmake tweaks #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `add_compile_options ("-W4")` instead of `add_definitions ("-W4")` since
the latter passes a `-W4` argument to `rc.exe` which results in this error:
fatal error RC1106: invalid option: -4
The same is done for non-MSVC compilers for consistency and to avoid similar
problems.
This avoids the following linker error: unresolved external symbol _MemoryModuleTestsuite referenced in function _main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces three tweaks to CMakeLists.txt:
add_compile_options ("-W4")option.TESTSUITEis disabledEach is in a separate commit. Each commit has some more details in its description.